-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEPR Enforce reversion of Size color aliases #49836
Conversation
Oh I missed this, so this is the actual implementation of the keyword arguments? If yes, lets enforce in 1.5.3, this can be considered a regression |
yup - 1.5.3 sounds good! will update the whatsnew now EDIT nvm, will wait for 1.5.3 whatsnew note |
Can you update the whatsnew? |
Oops, something went wrong applying the patch ... Please have a look at my logs. |
cc @MarcoGorelli could you backport manually? |
@meeseeksdev backport 1.5.x |
Oops, something went wrong applying the patch ... Please have a look at my logs. |
yeah will do tomorrow |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.Docs and whatsnew were added in #49734, let's enforce it in 2.0.0?