Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR Enforce reversion of Size color aliases #49836

Merged
merged 3 commits into from
Nov 23, 2022

Conversation

MarcoGorelli
Copy link
Member

Docs and whatsnew were added in #49734, let's enforce it in 2.0.0?

@phofl
Copy link
Member

phofl commented Nov 22, 2022

Oh I missed this, so this is the actual implementation of the keyword arguments?

If yes, lets enforce in 1.5.3, this can be considered a regression

@phofl phofl added this to the 1.5.3 milestone Nov 22, 2022
@MarcoGorelli
Copy link
Member Author

MarcoGorelli commented Nov 22, 2022

yup - 1.5.3 sounds good! will update the whatsnew now

EDIT nvm, will wait for 1.5.3 whatsnew note

@mroeschke mroeschke added the Visualization plotting label Nov 23, 2022
@rhshadrach rhshadrach added Regression Functionality that used to work in a prior pandas version Bug labels Nov 23, 2022
@phofl
Copy link
Member

phofl commented Nov 23, 2022

Can you update the whatsnew?

@phofl phofl merged commit d95bf9a into pandas-dev:main Nov 23, 2022
@lumberbot-app
Copy link

lumberbot-app bot commented Nov 23, 2022

Oops, something went wrong applying the patch ... Please have a look at my logs.

@phofl
Copy link
Member

phofl commented Nov 23, 2022

cc @MarcoGorelli could you backport manually?

@phofl
Copy link
Member

phofl commented Nov 23, 2022

@meeseeksdev backport 1.5.x

@lumberbot-app
Copy link

lumberbot-app bot commented Nov 23, 2022

Oops, something went wrong applying the patch ... Please have a look at my logs.

@MarcoGorelli
Copy link
Member Author

cc @MarcoGorelli could you backport manually?

yeah will do tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Regression Functionality that used to work in a prior pandas version Visualization plotting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Plotly scatter plots no longer produce color correctly, color alias for c in 1.5
4 participants