DEPR: Change numeric_only default to False in remaining groupby methods #49951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
added
Groupby
Deprecate
mroeschke
approved these changes
Nov 29, 2022
| mgr = mgr.get_numeric_data() | ||
|
|
||
| res_mgr = mgr.grouped_reduce(blk_func, ignore_failures=False) | ||
| res_mgr = mgr.grouped_reduce(blk_func) | ||
|
|
||
| if not is_ser and len(res_mgr.items) != orig_mgr_len: |
There was a problem hiding this comment.
im pretty sure L3780-L3790 should be unnecesary now
There was a problem hiding this comment.
OK for follow-up. lets merge this sucker
There was a problem hiding this comment.
It will never end, will it? 😆 I'll put up a followup shortly.
There was a problem hiding this comment.
ive got an "assorted cleanups" branch, will do it there
jbrockmendel
approved these changes
Nov 29, 2022
|
thanks @rhshadrach, exciting to see this go! dont forget to update #30228 |
Done. |
|
There are checkboxes for 40238 and 47561 that i'd expect to be checked off. am i being too hopeful here? |
|
Nope - those are done as well. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.