Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: deprecate Index.is_floating #50235

Merged
merged 11 commits into from
Jan 12, 2023

Conversation

yuuun
Copy link
Contributor

@yuuun yuuun commented Dec 13, 2022

@yuuun yuuun changed the title DEPR: deprecate Index.is_interval DEPR: deprecate Index.is_float Dec 13, 2022
@yuuun
Copy link
Contributor Author

yuuun commented Dec 14, 2022

@topper-123 Hi, Can you check if I have done right?
Can you tell me the next step I should do?

@topper-123 topper-123 added this to the 2.0 milestone Dec 14, 2022
@topper-123 topper-123 added Deprecate Functionality to remove in pandas Index Related to the Index class or subclasses labels Dec 14, 2022
Copy link
Contributor

@topper-123 topper-123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I’ll metge when the other ralated PRs get pulled in, so this may sit for a while

@phofl phofl merged commit 35ce27a into pandas-dev:main Jan 12, 2023
@phofl
Copy link
Member

phofl commented Jan 12, 2023

thx @yuuun

Comment on lines +2304 to +2305
f"{type(self).__name__}.is_floating is deprecated."
"Use pandas.api.types.is_float_dtype instead",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably could do with a space here.

phofl pushed a commit to phofl/pandas that referenced this pull request Jan 12, 2023
phofl pushed a commit to phofl/pandas that referenced this pull request Jan 13, 2023
@topper-123 topper-123 changed the title DEPR: deprecate Index.is_float DEPR: deprecate Index.is_floating Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas Index Related to the Index class or subclasses
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants