Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REGR: NumPy func warning when dropping nuisance in agg, apply, transform #50627

Merged
merged 2 commits into from
Jan 16, 2023

Conversation

rhshadrach
Copy link
Member

@rhshadrach rhshadrach added Regression Functionality that used to work in a prior pandas version Apply Apply, Aggregate, Transform, Map Warnings Warnings that appear or should be added to pandas Nuisance Columns Identifying/Dropping nuisance columns in reductions, groupby.add, DataFrame.apply labels Jan 7, 2023
@rhshadrach rhshadrach changed the title REGR: Warnings for NumPy funcs when dropping nuisance in agg, apply, transform REGR: NumPy func warning when dropping nuisance in agg, apply, transform Jan 7, 2023
@rhshadrach rhshadrach added this to the 1.5.3 milestone Jan 8, 2023
@rhshadrach
Copy link
Member Author

@jorisvandenbossche @jbrockmendel @mroeschke for any thoughts/feedback

@jorisvandenbossche
Copy link
Member

In case we keep the current behaviour (no special handling of numeric_only, just passing through), then this is at least a clear improvement in the warning messages!

@rhshadrach
Copy link
Member Author

@jorisvandenbossche - I think trying to change the pass through behavior is too tricky for a patch (this is targeted to go straight into 1.5.3). I do plan to work on it for future versions (e.g. #50624). If you want this to not close #50538, I can remove it from the OP here, but I do think this is the safest route for 1.5.3.

@rhshadrach
Copy link
Member Author

@mroeschke - friendly ping.

@rhshadrach rhshadrach mentioned this pull request Jan 14, 2023
2 tasks
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Agreed that improving the exception message here is more reasonable than try to shim numeric_only support of any kind

@mroeschke mroeschke merged commit ce123cd into pandas-dev:1.5.x Jan 16, 2023
@mroeschke
Copy link
Member

Thanks @rhshadrach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Apply Apply, Aggregate, Transform, Map Nuisance Columns Identifying/Dropping nuisance columns in reductions, groupby.add, DataFrame.apply Regression Functionality that used to work in a prior pandas version Warnings Warnings that appear or should be added to pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants