Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Use PyCapsule for internal datetime functions" #51951

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Revert "Use PyCapsule for internal datetime functions" #51951

merged 1 commit into from
Mar 14, 2023

Conversation

jbrockmendel
Copy link
Member

Reverts #51525

This is making #50960 a PITA.

This was referenced Mar 13, 2023
Merged
Closed
Closed
@jbrockmendel jbrockmendel merged commit 8487b2e into main Mar 14, 2023
@jbrockmendel jbrockmendel deleted the revert-51525-np-datetime-capsule branch March 14, 2023 23:24
@MarcoGorelli
Copy link
Member

Was there any discussion behind reverting this?

As far as I can tell, reverting this wasn't necessary for addressing #51961, and #50960 wasn't urgent

@jbrockmendel
Copy link
Member Author

I jumped the gun.

mroeschke added a commit to mroeschke/pandas that referenced this pull request Mar 16, 2023
@mroeschke
Revert "Revert "Use PyCapsule for internal datetime functions" (panda…
d7df99a 
…s-dev#51951)"

This reverts commit 8487b2e.
@mroeschke mroeschke mentioned this pull request Mar 16, 2023
Merged
lithomas1 pushed a commit that referenced this pull request Mar 18, 2023
@mroeschke
Re-land PyCapsule (#52021)
4ab82d0 
* Revert "Revert "Use PyCapsule for internal datetime functions" (#51951)"

This reverts commit 8487b2e.

* Revert "Revert "Re-enable parallel builds in CI" (#51952)"

This reverts commit c8ea34c.

* Revert "Revert "CI: parallel build follow up" (#51984)"

This reverts commit 93b5135.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @MarcoGorelli