-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLD: Split out tests into pandas_tests package #53007
base: main
Are you sure you want to change the base?
Changes from all commits
d3edcdf
8e0d861
bd83272
339dacc
eea0220
a5a89b3
48df264
d00e471
a43c9fe
b2c2b8c
d6ac87c
427ea4e
7174249
f50f110
9cbbb66
053ad48
f2573ee
547dcc1
1044441
f3c182a
06d3697
13063d8
8254943
9ed91e0
d4502af
b61a6a4
1a6531c
e00ecf5
799687f
1d6137b
792c011
2a78345
16f5964
b911945
beb64dc
3135e67
d17ddaf
50410ad
554d478
8d68f7d
98ec61a
b8e3588
a19f2e6
b4aa062
a2ba3bf
7ee6adc
19fa7f9
be64699
f1c18cc
e835993
5bdc0d1
2cf3911
e9ba935
e53ad08
23952aa
23b9827
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -189,6 +189,19 @@ | |
__git_version__ = v.get("full-revisionid") | ||
del get_versions, v | ||
|
||
import sys | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this break an API users potentially use. If so will we need a depr cycle? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Kinda. This is technically breaking, but the next release also happens to be 3.0, so I think we'd be able to get away with a breaking change here :) |
||
|
||
try: | ||
import pandas_tests # pyright: ignore [reportMissingImports] | ||
|
||
sys.modules["pandas.tests"] = pandas_tests | ||
|
||
del pandas_tests | ||
except ImportError: | ||
pass | ||
|
||
del sys | ||
|
||
|
||
# module level doc-string | ||
__doc__ = """ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is setuptools-scm a misnomer or does it have some kind of dependency with setuptools?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use it to version the pandas-tests package?
Setting up versioneer is probably overkill for pandas-tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm not sure I understand. So this does still require setuptools right? I think that is confusing given the work we have put into meson to replace that library
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, pandas-tests is built using setuptools.
I figured it was much easier to use setuptools given this is a pure Python package.
(Note that if you're just doing regular development you'll never need setuptools, unless you want to build pandas_tests by hand for some reason)