CLN: avoid upcasting in tests where unnecessary (PDEP-6 precursor) #53104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 5, 2023 13:41
MarcoGorelli
commented
May 5, 2023
| @@ -328,15 +328,14 @@ def test_where_bug_mixed(self, any_signed_int_numpy_dtype): | |||
| ) | |||
|
|
|||
| expected = DataFrame( | |||
| {"a": [np.nan, np.nan, 3.0, 4.0], "b": [4.0, 3.0, np.nan, np.nan]}, | |||
There was a problem hiding this comment.
changing this test to fill with -1 instead of with nan
There was a problem hiding this comment.
just checking: you looked at the original issue and confirmed this still tests the relevant bug?
There was a problem hiding this comment.
yeah the original issue is just about having mixed dtypes #2793 , I've preserved that but have just updated the fill value to one which won't upcast
I think I'm scraping the barrel here with these precursors, there's probably not much more to factor out which doesn't intentionally test upcasting behaviour
mroeschke
approved these changes
May 5, 2023
|
Thanks @MarcoGorelli |
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
May 7, 2023
…andas-dev#53104) * remove more upcasts * 🎨 --------- Co-authored-by: MarcoGorelli <>
Rylie-W
pushed a commit
to Rylie-W/pandas
that referenced
this pull request
May 19, 2023
…andas-dev#53104) * remove more upcasts * 🎨 --------- Co-authored-by: MarcoGorelli <>
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
…andas-dev#53104) * remove more upcasts * 🎨 --------- Co-authored-by: MarcoGorelli <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
another precursor to PDEP6, similar to #52957
turns out there were even more of these which could be factored upon further inspection