TYP: remove mypy ignore[assignment] from pandas/core/internals/construction.py #53135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natmokval
changed the title
|
Hi @MarcoGorelli, could you please take a look at this pr? |
Comment on lines
690
to
693
| # Incompatible types in assignment (expression has type | ||
| # "List[Union[ExtensionArray, ndarray[Any, Any], None]]", variable | ||
| # has type "List[Union[ExtensionArray, ndarray[Any, Any]]]") | ||
| arrays = new_arrays # type: ignore[assignment] | ||
| arrays = cast(list[ArrayLike], new_arrays) |
There was a problem hiding this comment.
is it possible to refactor instead of casting? it might be possible to be more precise here
something like
new_arrays: list[ArrayLike] = []
indexer = arr_columns.get_indexer(columns)
for i, k in enumerate(indexer):
if k == -1:
# by convention default is all-NaN object dtype
arr = np.empty(length, dtype=object)
arr.fill(np.nan)
else:
arr = arrays[k]
new_arrays.append(arr)then the cast might not be necessary? haven't tried running this (currently on a train 🚋), but hoping this might work
There was a problem hiding this comment.
Thank you, I did as you suggested. It works very well.
MarcoGorelli
approved these changes
May 11, 2023
|
let's ship it if you're interested in typing, I'd highly suggest you take a look at https://github.com/pandas-dev/pandas-stubs - that affects the type hints which users get, there's plenty of really useful issues to work on there (and feel free to reach out to Irv if you're not sure where to start) |
Rylie-W
pushed a commit
to Rylie-W/pandas
that referenced
this pull request
May 19, 2023
…uction.py (pandas-dev#53135) * remove mypy ignore[assignment] * replace casting with refactoring
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
…uction.py (pandas-dev#53135) * remove mypy ignore[assignment] * replace casting with refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #37715
mypy ignore[assignment] was removed from pandas/core/internals/construction.py