DEPR: positional indexing on Series __getitem__/__setitem__ #53201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Indexing
mroeschke
reviewed
May 19, 2023
| if index is d0: | ||
| warn = FutureWarning | ||
| with tm.assert_produces_warning(warn, match=msg): | ||
| assert s.get(10, "z") == "z" |
There was a problem hiding this comment.
Why does this case raise a FutureWarning? I would expect Series.get to always act like label based indexing with fallback
There was a problem hiding this comment.
NDFrame.get is a try/except around __getitem__. xref #17928
There was a problem hiding this comment.
Ah that's annoying. Okay makes sense here
mroeschke
approved these changes
May 19, 2023
|
Thanks @jbrockmendel |
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
May 22, 2023
…ev#53201) * DEPR: positional indexing on Series __getitem__/__setitem__ * troubleshoot docs * troubleshoot docs * update doc * update docs * docs * update fixture * update doctest
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
…ev#53201) * DEPR: positional indexing on Series __getitem__/__setitem__ * troubleshoot docs * troubleshoot docs * update doc * update docs * docs * update fixture * update doctest
Merged
3 tasks
galipremsagar
added a commit
to rapidsai/cudf
that referenced
this pull request
Dec 19, 2023
…em__ (#14654) This PR deprecates positional access in `Series.__getitem__` when a label-based index is present. xref: pandas-dev/pandas#53201 On `pandas_2.0_feature_branch`: ``` = 260 failed, 101179 passed, 2091 skipped, 954 xfailed, 312 xpassed in 1104.58s (0:18:24) = ``` This PR: ``` = 248 failed, 101190 passed, 2091 skipped, 954 xfailed, 312 xpassed in 1105.78s (0:18:25) = ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.xref #50617, possibly closes