CLN: Fix return type for initObjToJSON()

[jtratner]

Make it so that it always returns the same thing as numpy, so that it
matches the right signature whether in or not in the error condition.

Closes #5326.

[jtratner]

Here's the in-a-nutshell of why this is necessary: http://stackoverflow.com/questions/10509400/difference-between-pymodinit-func-and-pymodule-create

In Python 2.X the module init function could return void, in 3.X needs to return PyObject* (or NULL). I guess numpy assumes you'd use import_arrays() in a function whose signature is PyMODINIT_FUNC and therefore conveniently includes the appropriate return that you'd need on an error importing numpy multiarray. We weren't actually handling the non-error case correctly - thanks to @toddrme2178 for catching this!

[Komnomnomnom]

Thanks @jtratner for digging into this. Fix looks good.

[jtratner]

flipped this to match numpy's format for clarity.

[jreback]

fyi...this builds on windows! so that is good

[jtratner]

good, and it ought to build on openSUSE too...

[toddrme2178]

I can confirm this fixes the problem on openSUSE. Thank you for the prompt
fix. I have backported the patch to the 0.12.0 release.

On Sun, Oct 27, 2013 at 1:41 AM, Jeff Tratner notifications@git.luolix.topwrote:

good, and it ought to build on openSUSE too...

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/5334#issuecomment-27158343
.

[jtratner]

No problem - thanks for reporting this! - it was a subtle error (and it was
helpful to look into the numpy C API further). It also speaks to the
utility of the openSUSE build QC. :)