-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEPR: Positional arguments in to_sql except name #54397
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
8b04508
Updated method header and whatsnew file
rmhowe425 432ebbe
Updated unit tests to use keyword argument for con parameter.
rmhowe425 567e918
Updating unit tests and implementation.
rmhowe425 8072f8c
Merge branch 'main' into dev/keyword/to_sql
rmhowe425 c4c8bae
Merge branch 'main' into dev/keyword/to_sql
rmhowe425 a8f9d0b
Updated documentation and unit tests.
rmhowe425 e8862d3
Updating documentation and fixing unit tests.
rmhowe425 afb4cc4
Updating documentation.
rmhowe425 a8c0baf
Updating documentation and fixing failing unit tests.
rmhowe425 b7bd1ed
Updating documentation and unit tests.
rmhowe425 2907ed0
Updating implementation based on reviewer feedback.
rmhowe425 3ab46ac
Updating implementation to allow 'self' to be a positional arg.
rmhowe425 b595a81
Merge branch 'main' into dev/keyword/to_sql
rmhowe425 3028872
Deprecating con positional arg in new test case.
rmhowe425 56ec5d2
Fixing typo
rmhowe425 71ac556
Fixing typo
rmhowe425 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might make sense to allow
con
as positional as well?(certainly given that it is a required argument, quite self-descriptive (eg not a boolean argument), and that this pattern is widely used in our own docs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I can see that being reasonable. I don't have super strong feelings about it though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if I need to update the PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @jorisvandenbossche,
con
is a weird name, I'd allow this to be positional as well (personally never specified it). Opened #54749 and PR is incoming, this should go into 2.1