ENH: use shutil.which() instead of external which(1) #54937
Conversation
|
I wasn't sure how to classify this: I chose "ENH" because I suppose removing unnecessary dependency is an "enhancement". However, this is quite trivial and I'd love to see it in 2.1.1. |
|
Ideally, your PR would make it into https://github.com/asweigart/pyperclip and then a PR here to update the pyperclip copy - but that repository seems rather inactive. |
|
Well, there's a bit of a problem with that since technically pyperclip still supports Python 2.7, and I don't think there's really point in going over the burden of implementing backwards compatibility given that the author is unresponsive for 2 years already. |
|
An option could be to first update the copy to the "latest" version. Assuming it is the last version ever to be released, clean it (remove py2 stuff), and then use shutil.which. Can then also add type annotations later. |
|
Yeah agreed since pyperclip seems unmaintained, it would be best to update our vendor to the latest version before making any changes |
|
Just to be clear, by "latest" do you mean the HEAD of git repository, or the release from PyPI? I suppose I could fork the repository and make a PR with a note that it breaks py2.7 compat, if that helps. If the project is ever revived, it'll probably drop py2 support anyway. Long term it might be a good idea to look for a maintained replacement too. |
|
I would take the latest released version from pypi as it might be more well-tested. As the project seems inactive/dead, I personally wouldn't bother opening a PR there and instead, I would just copy the latest |
Copy the changes from upstream 1.8.2 to the bundled copy of pyperclip. The code was reformatted using black and verified using ruff. The existing modifications from pandas were preserved.
Remove the fallback to which/where that is only necessary for Python 2 that does not feature shutil.which(). Also collapse the imports to avoid importing shutil.which() twice. It is now only imported as `_executable_exists()` to minimize the changes to the original code.
|
I've copied the changes from 1.8.2 release. Incidentally, they included the use of |
Looking at #51744 (comment), I think not. We should probably move the |
Probably better to keep it as-is. There is also an issue to even deprecate it #52129 |
|
Ok, thanks. By the way, it just occurred to me to check pyperclip PR tracker, and indeed there's a fix proposed along the lines of what I thought: asweigart/pyperclip#201. So if you prefer, I can just include that. |
Personally, I have no preference (I honestly wouldn't mind deprecating clipboard). Since this is still mostly a 1:1 copy, it might be better to make as few changes as possible. @mroeschke |
* ENH: update bundled pyperclip with changes from 1.8.2 release Copy the changes from upstream 1.8.2 to the bundled copy of pyperclip. The code was reformatted using black and verified using ruff. The existing modifications from pandas were preserved. * ENH: Remove Python 2 compatibility from imported pyperclip code Remove the fallback to which/where that is only necessary for Python 2 that does not feature shutil.which(). Also collapse the imports to avoid importing shutil.which() twice. It is now only imported as `_executable_exists()` to minimize the changes to the original code. * BUG: Fix pylint failure (redundant `pass`) in clipboard
Use the
shutil.which()function to determine whether executables exist rather than calling the externalwhich(1)orwhereprogram. This program is not a part of POSIX base system, and modern Linux distributions are working towards making it completely optional. The builtinshutil.which()is available since Python 3.3 and already used in the same file.This makes it possible to remove the dependency on
sys-apps/whichfrom Gentoo systems.doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.