Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more changes to setup.py #572

Conversation

gregglind
Copy link
Contributor

Maybe consider just making people use either setuptools or distribute?

@wesm
Copy link
Member

wesm commented Jan 4, 2012

I have had ongoing problems with setuptools's interactions with Cython. If you can figure out how to get setuptools to play nice with my Cython extensions, then I will do it. Otherwise I can't accept the patch

@gregglind
Copy link
Contributor Author

Is it just setuptools in particular, or distribute also? Distribute seems to work right on OSX (I don't have a windows machine to test it on). Is this different than your experience?

It seems this is 'known fixed' in distribute: https://bitbucket.org/tarek/distribute/issue/195/cython-build_ext-support-broken-when-using

So, big picture, and my goals here:

  • I want setup.py to be as friendly as possible when failing
  • I want pip install to get as much as possible right, without too much headache (the numpy bit is a bit of a headache!)

If that's not possible, then maybe a 'suggested install style' should go out with the package... something like:

try:
import Numpy, dateutil, .....
except:
print "these onese failed.... here's how to install them"

With a lot of notes saying (in code) why we don't use the 'install_requires' bits.

@gregglind
Copy link
Contributor Author

Perhaps as an alternative, it might be worth cribbing from lxml's setup process...

https://github.com/lxml/lxml

Clearly, this can wait :)

@wesm
Copy link
Member

wesm commented Jan 4, 2012

That's a good idea. Wouldn't mind trying to get this done for 0.7.0

@gregglind
Copy link
Contributor Author

I can confirm that things are borked under setuptools in osx, and they do work fine under distribute. Frustrating stuff!

@wesm
Copy link
Member

wesm commented Jan 4, 2012

here's an open issue related to the setuptools bug

https://github.com/wesm/pandas/issues/192

@wesm
Copy link
Member

wesm commented Jan 6, 2012

Cherry-picked and merged per #578

@wesm wesm closed this Jan 6, 2012
dan-nadler pushed a commit to dan-nadler/pandas that referenced this pull request Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants