Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: dt64 + DateOffset with milliseconds #57536

Merged
merged 3 commits into from
Feb 20, 2024
Merged

BUG: dt64 + DateOffset with milliseconds #57536

merged 3 commits into from
Feb 20, 2024

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke added Datetime Datetime data dtype Numeric Operations Arithmetic, Comparison, and Logical operations Frequency DateOffsets labels Feb 20, 2024
WillAyd
WillAyd approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. nanoseconds is implicitly handled right?

@mroeschke
Copy link
Member Author

lgtm. nanoseconds is implicitly handled right?

Yeah I believe so a few lines above the last elif "milliseconds" in kwds: added check

@mroeschke mroeschke added this to the 2.2.1 milestone Feb 20, 2024
@mroeschke mroeschke merged commit 7a5a5c7 into pandas-dev:main Feb 20, 2024
53 checks passed
@mroeschke mroeschke deleted the bug/ts_offset/milli branch February 20, 2024 19:50
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Feb 20, 2024
@mroeschke @meeseeksmachine
Backport PR pandas-dev#57536: BUG: dt64 + DateOffset with milliseconds
c051d43
@meeseeksmachine meeseeksmachine mentioned this pull request Feb 20, 2024
Merged
mroeschke added a commit that referenced this pull request Feb 20, 2024
@meeseeksmachine @mroeschke
Backport PR #57536 on branch 2.2.x (BUG: dt64 + DateOffset with milli…
0b49cf3 
…seconds) (#57537)

Backport PR #57536: BUG: dt64 + DateOffset with milliseconds

Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
@mroeschke @pmhatre1
BUG: dt64 + DateOffset with milliseconds (pandas-dev#57536)
b76e6f3 
* BUG: dt64 + DateOffset with milliseconds

* remove print
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

Assignees
No one assigned
Labels
Datetime Datetime data dtype Frequency DateOffsets Numeric Operations Arithmetic, Comparison, and Logical operations
Projects
None yet
Milestone
2.2.1
Development

Successfully merging this pull request may close these issues.

BUG: Binary op with datetime offset is resulting in incorrect results
2 participants
@mroeschke @WillAyd