Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PyArrow deprecation warning #57556

Merged
merged 4 commits into from
Feb 22, 2024
Merged

Conversation

phofl
Copy link
Member

@phofl phofl commented Feb 21, 2024

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@phofl phofl requested a review from mroeschke as a code owner February 21, 2024 22:21
@phofl phofl added this to the 2.2.1 milestone Feb 21, 2024
pandas/__init__.py Outdated Show resolved Hide resolved
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
@mroeschke mroeschke added the Warnings Warnings that appear or should be added to pandas label Feb 22, 2024
@lithomas1
Copy link
Member

/preview

Copy link
Contributor

Website preview of this PR available at: https://pandas.pydata.org/preview/pandas-dev/pandas/57556/

@lithomas1 lithomas1 merged commit 4ed67ac into pandas-dev:main Feb 22, 2024
51 checks passed
@lithomas1
Copy link
Member

thanks @phofl.

Copy link

lumberbot-app bot commented Feb 22, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.2.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 4ed67ac9ef3d9fde6fb8441bc9ea33c0d786649e
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #57556: Remove PyArrow deprecation warning'
  1. Push to a named branch:
git push YOURFORK 2.2.x:auto-backport-of-pr-57556-on-2.2.x
  1. Create a PR against branch 2.2.x, I would have named this PR:

"Backport PR #57556 on branch 2.2.x (Remove PyArrow deprecation warning)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@phofl
Copy link
Member Author

phofl commented Feb 22, 2024

I'll do the backport

@phofl phofl deleted the dep_warning branch February 22, 2024 17:43
phofl added a commit to phofl/pandas that referenced this pull request Feb 22, 2024
* Revert "DEPS: Add warning if pyarrow is not installed (pandas-dev#56896)"

This reverts commit 5c2a407

* Add whatsnew

* Update

* Update doc/source/whatsnew/v2.2.1.rst

Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>

---------

Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>

(cherry picked from commit 4ed67ac)
@phofl
Copy link
Member Author

phofl commented Feb 22, 2024

#57558

pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
* Revert "DEPS: Add warning if pyarrow is not installed (pandas-dev#56896)"

This reverts commit 5c2a407

* Add whatsnew

* Update

* Update doc/source/whatsnew/v2.2.1.rst

Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>

---------

Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Warnings Warnings that appear or should be added to pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants