Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Assignment of pyarrow arrays yield unexpected dtypes #58601

Open
wants to merge 47 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
b29fb0f
ArrowDtype type are taken into account in a column assignment
droussea2001 May 1, 2024
bfbd7dc
Add test for pyarrow assignment in column test_assign_pyarrow_columns
droussea2001 May 1, 2024
04b1edc
force dtype cast in _sanitize_column only for pa.lib.Array
droussea2001 May 1, 2024
5d2016d
move test_assign_column_in_dataframe from test_alter_axes.py to test_…
droussea2001 May 2, 2024
61c0697
Merge remote-tracking branch 'upstream/main' into BUG-56994/pyarrow-a…
droussea2001 May 2, 2024
4ed7820
Merge remote-tracking branch 'upstream/main' into BUG-56994/pyarrow-a…
droussea2001 May 6, 2024
86efdfd
test_assign_column_in_dataframe is configurable by the data fixture
droussea2001 May 6, 2024
e7e3a8b
manage optional pyarrow import
droussea2001 May 6, 2024
da3f135
Integrate docstring correction
droussea2001 May 7, 2024
9c53b89
add an xfail to test_assign_column_in_dataframe to manage version wit…
droussea2001 May 7, 2024
f28b026
correct pyarrow version check
droussea2001 May 7, 2024
703a0c6
Correct wrong pyarrow check
droussea2001 May 17, 2024
0f924e1
Remove unnecessary xfail
droussea2001 May 17, 2024
def88e2
Merge branch 'main' into BUG-56994/pyarrow-assignment-unexpected-dtypes
droussea2001 May 17, 2024
0a914da
Merge branch 'main' into BUG-56994/pyarrow-assignment-unexpected-dtypes
droussea2001 Jun 20, 2024
5aeac95
Move pyarrow check in sanitize_array
droussea2001 Jun 20, 2024
2f07cc0
Move pyarrow check in sanitize_array
droussea2001 Jun 20, 2024
a94023f
Code clean up
droussea2001 Jun 20, 2024
e69265b
Check if dtype has been initialized before
droussea2001 Jun 21, 2024
cc092e3
Merge remote-tracking branch 'upstream/main' into BUG-56994/pyarrow-a…
droussea2001 Jun 21, 2024
12727f0
Try to process arrow dtype before any dtype modification
droussea2001 Jun 21, 2024
2c7912b
Merge branch 'main' into BUG-56994/pyarrow-assignment-unexpected-dtypes
droussea2001 Jun 24, 2024
7c15d07
Merge branch 'main' into BUG-56994/pyarrow-assignment-unexpected-dtypes
droussea2001 Jun 25, 2024
0f1c524
Merge branch 'main' into BUG-56994/pyarrow-assignment-unexpected-dtypes
droussea2001 Jun 26, 2024
e983264
Merge branch 'main' into BUG-56994/pyarrow-assignment-unexpected-dtypes
droussea2001 Jun 26, 2024
bd38f15
Add entry in last new in section Conversion
droussea2001 Jun 27, 2024
96871c1
Replace pyarrow type check by existing lib function
droussea2001 Jun 27, 2024
fadf487
Merge branch 'BUG-56994/pyarrow-assignment-unexpected-dtypes' of http…
droussea2001 Jun 27, 2024
5dadf0e
Merge remote-tracking branch 'upstream/main' into BUG-56994/pyarrow-a…
droussea2001 Jun 27, 2024
747756f
Merge branch 'main' into BUG-56994/pyarrow-assignment-unexpected-dtypes
droussea2001 Jul 28, 2024
fca36ea
Merge branch 'main' into BUG-56994/pyarrow-assignment-unexpected-dtypes
droussea2001 Jul 30, 2024
ad3d736
Merge branch 'main' into BUG-56994/pyarrow-assignment-unexpected-dtypes
droussea2001 Aug 1, 2024
4773051
Merge branch 'main' into BUG-56994/pyarrow-assignment-unexpected-dtypes
droussea2001 Aug 9, 2024
a4dc614
Merge branch 'main' into BUG-56994/pyarrow-assignment-unexpected-dtypes
droussea2001 Aug 24, 2024
4e03be0
Merge branch 'main' into BUG-56994/pyarrow-assignment-unexpected-dtypes
droussea2001 Sep 9, 2024
97c8e56
Merge branch 'main' into BUG-56994/pyarrow-assignment-unexpected-dtypes
droussea2001 Oct 11, 2024
1805626
Merge branch 'main' into BUG-56994/pyarrow-assignment-unexpected-dtypes
droussea2001 Oct 31, 2024
dadf6fc
Merge branch 'main' into BUG-56994/pyarrow-assignment-unexpected-dtypes
droussea2001 Nov 2, 2024
9cc063e
Update description of issue 56994
droussea2001 Nov 3, 2024
bf98984
Code clean up
droussea2001 Nov 3, 2024
64a366d
Test assignment from a pyarrow array and a series
droussea2001 Nov 3, 2024
8f115c6
Merge branch 'main' into BUG-56994/pyarrow-assignment-unexpected-dtypes
droussea2001 Nov 3, 2024
01812ef
Add test for series instanciation with pyarrow type
droussea2001 Nov 4, 2024
89f0429
Merge branch 'BUG-56994/pyarrow-assignment-unexpected-dtypes' of http…
droussea2001 Nov 4, 2024
de9caf6
Merge branch 'main' into BUG-56994/pyarrow-assignment-unexpected-dtypes
droussea2001 Nov 4, 2024
ad1db19
Merge branch 'main' into BUG-56994/pyarrow-assignment-unexpected-dtypes
droussea2001 Nov 8, 2024
a9f000c
Merge branch 'main' into BUG-56994/pyarrow-assignment-unexpected-dtypes
droussea2001 Nov 22, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Code clean up
  • Loading branch information
droussea2001 authored Jun 20, 2024
commit a94023fd5b17c124e5b0e578e4b4cea6884c09b7
1 change: 0 additions & 1 deletion pandas/core/frame.py
Original file line number Diff line number Diff line change
@@ -5082,7 +5082,6 @@ def _sanitize_column(self, value) -> tuple[ArrayLike, BlockValuesRefs | None]:

if is_list_like(value):
com.require_length_match(value, self.index)

return sanitize_array(value, self.index, copy=True, allow_2d=True), None

@property
Loading