Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLD: Fix bad Cython annotation #59836

Merged
merged 2 commits into from
Sep 18, 2024
Merged

BLD: Fix bad Cython annotation #59836

merged 2 commits into from
Sep 18, 2024

Conversation

lithomas1
Copy link
Member

@lithomas1 lithomas1 commented Sep 18, 2024 •
edited
Loading

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Cython changed something, this fixes the 3.13 builds using the latest Cython

@lithomas1 lithomas1 added the Build Library building on various platforms label Sep 18, 2024
@lithomas1 lithomas1 added this to the 2.2.3 milestone Sep 18, 2024
@lithomas1 lithomas1 marked this pull request as ready for review September 18, 2024 20:17
@lithomas1 lithomas1 added Compat pandas objects compatability with Numpy or Python functions Python 3.13 labels Sep 18, 2024
MarcoGorelli
MarcoGorelli approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @lithomas1 , it was probably my fault for having written it like that

@lithomas1 lithomas1 merged commit 09c7a87 into pandas-dev:main Sep 18, 2024
96 of 167 checks passed
@lithomas1 lithomas1 deleted the fix-bad-annotation branch September 18, 2024 21:16
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Sep 18, 2024
@lithomas1 @meeseeksmachine
Backport PR pandas-dev#59836: BLD: Fix bad Cython annotation
0c605c0
@meeseeksmachine meeseeksmachine mentioned this pull request Sep 18, 2024
Merged
@lithomas1
Copy link
Member Author

thanks @lithomas1 , it was probably my fault for having written it like that

No not at all, it wasn't until very recently that Cython tried to optimize Python annotations.

jorisvandenbossche pushed a commit that referenced this pull request Sep 18, 2024
@meeseeksmachine @lithomas1
Backport PR #59836 on branch 2.2.x (BLD: Fix bad Cython annotation) (#…
8d67e77 
…59837)

Backport PR #59836: BLD: Fix bad Cython annotation

Co-authored-by: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Build Library building on various platforms Compat pandas objects compatability with Numpy or Python functions Python 3.13
Projects
None yet
Milestone
2.2.3
Development

Successfully merging this pull request may close these issues.
2 participants
@lithomas1 @MarcoGorelli