-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add Styler.to_typst()
#60733
base: main
Are you sure you want to change the base?
ENH: Add Styler.to_typst()
#60733
Conversation
dda68e3
to
518e5c3
Compare
I think this is a nice, minimalist implementation of Provided the tests pass I am supportive of adding this in. Would need a "whatsnew" |
518e5c3
to
becfb36
Compare
5863c8a
to
8f149ab
Compare
Hi @attack68, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a neat well packaged addition to Styler outputs, and typst is gaining more attention.
The only omission I can spot is that it might need a link to be added to the "Styler Guide" which is the ipynb file. However, this is not necessary and can be added as a follow up.
Tests will need to pass, please look into failures and state if you think they are unrelated.
@mroeschke want to have a second look? |
pandas/io/formats/style.py
Outdated
""" | ||
Write Styler to a file, buffer or string in Typst format. | ||
.. versionadded:: 2.3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. versionadded:: 2.3.0 | |
.. versionadded:: 3.0.0 |
doc/source/whatsnew/v2.3.0.rst
Outdated
^^^^^^^^^^^^ | ||
|
||
- The :meth:`.Styler.to_typst` function has been added to write Styler to a file, buffer or string in Typst format (:issue:`57617`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move this to 3.0.0?
52bee29
to
058327c
Compare
(Styler|DataFrame).to_typst()
#57617doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.