Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: deprecate cols / change to columns in to_csv / to_excel #6686

Closed
wants to merge 2 commits into from

Conversation

jsexauer
Copy link
Contributor

Fix #6645

@jorisvandenbossche
Copy link
Member

I think there are also some occurences in the docs:

>>>-------------------------------------------------------------------------
Warning in /tmp/doc/source/comparison_with_r.rst at block ending on line 175
Specify :okwarning: as an option in the ipython:: block to suppress this message
----------------------------------------------------------------------------
/home/travis/virtualenv/python2.7_with_system_site_packages/local/lib/python2.7/site-packages/pandas/tools/pivot.py:82: FutureWarning: cols is deprecated, use columns

warnings.warn("cols is deprecated, use columns", FutureWarning)
<<<-------------------------------------------------------------------------

>>>-------------------------------------------------------------------------
Warning in /tmp/doc/source/comparison_with_r.rst at block ending on line 407
Specify :okwarning: as an option in the ipython:: block to suppress this message
----------------------------------------------------------------------------
/home/travis/virtualenv/python2.7_with_system_site_packages/local/lib/python2.7/site-packages/pandas/tools/pivot.py:73: FutureWarning: rows is deprecated, use index

warnings.warn("rows is deprecated, use index", FutureWarning)
<<<-------------------------------------------------------------------------

Otherwise looking OK!

@jorisvandenbossche
Copy link
Member

ah, it is still from the pivot/pivot_table PR, but still needs to be updated.

@jtratner
Copy link
Contributor

Btw - you can also explicitly set the warnings module run to raise on
warnings...
On Mar 22, 2014 1:04 AM, "Joris Van den Bossche" notifications@github.com
wrote:

ah, it is still from the pivot/pivot_table PR, but still needs to be
updated.

Reply to this email directly or view it on GitHubhttps://github.com//pull/6686#issuecomment-38345685
.

@jsexauer
Copy link
Contributor Author

Fixed two noted issues in docs. @jorisvandenbossche I couldn't find the result you pasted in any of the test jobs; how did you find that result?

@jorisvandenbossche
Copy link
Member

You would get the same if you build the docs yourself, but Travis also builds the docs, very handy! In the log of Travis, almost at the bottom, you have $ if [ -f /tmp/doc.log ]; then cat /tmp/doc.log; fi, where you get the output of the docs builds (you have to look at travis job 3, with DOC_BUILD=true)

@jorisvandenbossche
Copy link
Member

@jsexauer And you still missed 1 occurence of cols and 2 of rows in comparison_with_r.rst (the docs only give one warning, because always only the first one is warned for)

@jreback jreback modified the milestones: 0.15.0, 0.14.0 Mar 22, 2014
@jreback
Copy link
Contributor

jreback commented Mar 22, 2014

@jsexauer looks fine....pls create an issue to implement the removal of this code (reference this issue); i'll tag and put in 0.16.

@jorisvandenbossche @jtratner ok with this?

@jreback
Copy link
Contributor

jreback commented Mar 22, 2014

@jsexauer #6680 has your name on it too!

@jsexauer
Copy link
Contributor Author

Just amended #6581, figured best keep it all in one ticket when we have to remove it all :)

@jsexauer
Copy link
Contributor Author

Closing issue. Going to fix in #6693 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DEPR: deprecate cols / change to columns in to_csv / to_excel
4 participants