Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Bug in consistency of groupby aggregation when passing a custom function (GH6715) #6718

Merged
merged 1 commit into from
Mar 28, 2014

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Mar 27, 2014

closes #6715

@jreback jreback added this to the 0.14.0 milestone Mar 27, 2014
@jreback
Copy link
Contributor Author

jreback commented Mar 27, 2014

@jorisvandenbossche works but is a big hacky

@jorisvandenbossche
Copy link
Member

Thanks! Will test it this evening.

@jorisvandenbossche
Copy link
Member

For g.agg(P1) it does work, but g.apply(P1) not yet (or this way maybe not meant to fix that?). It just seems intuitive if you can do df.apply(P1, that you also can do g.apply(P1)

@jreback
Copy link
Contributor Author

jreback commented Mar 27, 2014

g.apply(P1) is correct as it is passed as a full dataframe (and not series by series). I don't see a way to avoid doing that. The paths groupby takes are pretty complicated. So not going to be able to fix. If you want to create a separeate issue maybe can address in 0.15.

jreback added a commit that referenced this pull request Mar 28, 2014
BUG: Bug in consistency of groupby aggregation when passing a custom function (GH6715)
@jreback jreback merged commit 1ff776a into pandas-dev:master Mar 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent result with applying function between dataframe/groupby apply and 0.12/0.13/master
2 participants