Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove number of deprecated parameters/functions/classes [fix #6641] #6813

Merged
merged 1 commit into from
Apr 8, 2014

Conversation

jsexauer
Copy link
Contributor

@jsexauer jsexauer commented Apr 5, 2014

Fixes #6641

Line numbers as of commit 70de129:

Deprecated since 0.11 or before

The following are fixed in this PR:

Deprecated since 0.12 or after

Issue #6581 documents the following for future removal. These are not included in this PR

@jsexauer
Copy link
Contributor Author

jsexauer commented Apr 5, 2014

Wanted to double-check that you want me to remove DateRange as it will be a more significant undertaking than the other ones. In addition to being available at the base of the API, it's used throughout the codebase, so I'll have to refactor all that too. Not a problem to do, but wanted to double-check before doing so.

@jreback
Copy link
Contributor

jreback commented Apr 5, 2014

can certainly leave that for now
but do it a separate pr if u can
it's just really a name for DatetimeIndex

FYI also need to check/update vbenches for any of these deprs

@jsexauer
Copy link
Contributor Author

jsexauer commented Apr 5, 2014

Not sure what the vbenches are? Is that what's in the vb_suite directory?

If so, here are the two places with FutureWarning

You don't want me to delete those do you?

@jtratner
Copy link
Contributor

jtratner commented Apr 6, 2014

@jsexauer - let's leave out deprecating DateRange for another issue so we can make this a minor change that we can accept. If it's still used within pandas and on the vbenches, it doesn't really feel like DateRange is deprecated.

@jtratner
Copy link
Contributor

jtratner commented Apr 6, 2014

i.e. you can just open a separate PR that handles the refactor and deprecation for DateRange.

yearfirst=yearfirst)
else:
data = tools.to_datetime(data, errors='raise')
data.offset = offset
data.offset = freq
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is slightly confusing to me - we deprecated offset as a parameter but not the actual offset property on the object?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct; there is no notation I can find that says the offset property of the pandas Timestamp object is deperated. However, freq is an alias of offset:

https://github.com/pydata/pandas/blob/master/pandas/tslib.pyx#L258

@jsexauer
Copy link
Contributor Author

jsexauer commented Apr 6, 2014

Ok I will do the DateRange one next. Just made a small change I saw in updating the docs (shouldn't affect tests). I think this one is ready for closing; let me know if more work is needed.

@jreback jreback added this to the 0.14.0 milestone Apr 6, 2014
@jreback
Copy link
Contributor

jreback commented Apr 6, 2014

can you edit #6581 to update the >= 0.12 (that we are going to deprecate in the future)?

thanks

@jreback
Copy link
Contributor

jreback commented Apr 6, 2014

anyone have a problem with any of this, these are all removed deprecations that were in effect <= 0.11 (so a while ago). That were announced to be removed in a future version.

@jsexauer @jtratner @jorisvandenbossche @TomAugspurger @cpcloud @hayd @wesm

@cpcloud
Copy link
Member

cpcloud commented Apr 6, 2014

Looks good, but I don't see the html.py removal listed in the task list.

@jsexauer
Copy link
Contributor Author

jsexauer commented Apr 6, 2014

@cpcloud It is the second to last item in the "Deprecated since 0.12" list. I see that the warning message says to remove in 0.14, but warning was given only in 0.13. Let me know if you want me to remove anyways.

@cpcloud
Copy link
Member

cpcloud commented Apr 6, 2014

oh ok ... you're right ... sorry i haven't looked at html stuff in a while, carry on

@jreback
Copy link
Contributor

jreback commented Apr 6, 2014

yep....only doing < 0.12 announced deprecations (which their are a lot!)

@wesm
Copy link
Member

wesm commented Apr 6, 2014

I'm pretty wary of removing load and save since they're used in The Book. I'm not sure if any of these other deprecation will affect the book but should try to avoid if possible, I guess.

@jreback
Copy link
Contributor

jreback commented Apr 6, 2014

save/load not on the table as those where from. 0.12

@jsexauer in the list can u out the version that the depr happened (I know I have the commit but for reference) thanks

@jsexauer
Copy link
Contributor Author

jsexauer commented Apr 8, 2014

@wesm I don't own a copy of The Book unfortunately, but assuming it was written for v0.9 (given publish in Oct 2012) the only two of these that might affect it are

  • the removal of the unique keyword from HDFStore.select_column
  • deprecation of name in favor of symobls in pandas.io.data.get_data_yahoo and pandas.io.data.get_data_google

Do you know if either of these were used?

@jreback Modified inital PR comment to include versions of first deprecation. Also moved all deprecations not pulled out in this PR into #6581.

@hayd
Copy link
Contributor

hayd commented Apr 8, 2014

Neither of those are used in wes' book.

@jreback
Copy link
Contributor

jreback commented Apr 8, 2014

yep...i think this is all fine.

@jreback jreback merged commit c0bf1d7 into pandas-dev:master Apr 8, 2014
@jreback
Copy link
Contributor

jreback commented Apr 8, 2014

thanks @jsexauer

@jreback
Copy link
Contributor

jreback commented Apr 8, 2014

@jsexauer ok..this is merged, but can you do a follow up fix the issues in v0.14.0 (and prob in release.rst), so that they are the original issues numbers (and not the deprecation issue).

http://pandas-docs.github.io/pandas-docs-travis/whatsnew.html#whatsnew-0140-prior-deprecations

e.g. if you are looking thru that page you want to be able to click thru and see what the original issue was.

@jsexauer
Copy link
Contributor Author

jsexauer commented Apr 8, 2014

What should I do for the ones that that didn't have issues?

@jreback
Copy link
Contributor

jreback commented Apr 8, 2014

if u have a commit reference then u can use that (though u may have to do an inline reference)
if u can get it to work great if leave the existing referemce

@jsexauer
Copy link
Contributor Author

jsexauer commented Apr 9, 2014

Have an example you could point me to?

@jreback
Copy link
Contributor

jreback commented Apr 9, 2014

oh...looking in cookbook.rst, its just another external link. (The issues render differently/automatically, via the issue number), but a commit is just a reference like any other HTML link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DEPR: create issues for the current FutureWarnings in pandas
6 participants