BUG: Error in rolling_var if window is larger than array, fixes #7297 #7572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 26, 2014
|
@jaimefrio thanks for the fix, just need tests from #7297 (If you want to add ok too). I don't think cc @kdiether has pull his request (yet) |
|
@jaimefrio can you incorporate those tests in the #7297 (if you want to add more complete tests go for it as discussed there). but want to put this in place for 0.14.1 |
|
Sure, hopefully will get it done tonight, tomorrow at the latest. Will ping here once the tests are in and Travis is OKing it. |
|
pls add a release note in v0.14.1.txt as well thxs |
|
hows this coming? |
|
Let's see what Travis thinks, but I think this should be it. |
|
The error is unrelated, some Travis setup failure. |
jreback
added a commit
that referenced
this pull request
Jul 2, 2014
BUG: Error in rolling_var if window is larger than array, fixes #7297
|
@jaimefrio thanks for the fixes! (sometimes travis get stuck....I just restarted and all good) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7297
Other rolling window functions rely on the logic in
_check_minp, and split the iteration into the ranges[0, minp-1)and(minp-1, N). Because of the wayrolling_varhandles things, splitting the iteration into[0, win)and(win, N)makes more sense. Added also some comments as to what is going on elsewhere in the code.No tests have been added, as @kdiether seems to have that very advanced.