Allow scroll on main content overflowing elements + fix anchor links #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoetmaaiers
changed the title
hoetmaaiers
force-pushed
the
bugfix/anchor-links
branch
from
7b00613 to
03d642f
Compare
|
This works perfect in the preview demo for the large tables! And for code blocks, it seems we already get this |
jorisvandenbossche
approved these changes
May 8, 2020
|
And the anchor link offsets are also fixed! 😄 |
|
Thanks @hoetmaaiers |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows scrolling on main content overflowing elements. Currently only
tablelike elements are in need of a scrollbar. Future elements can be added.Also anchor linkings are working as expected.
This replaces #148 with a much more elegant solution. Although the search for this solution took more time and effort then the resulting css might suggest.
Closes #147