Add large image to demo site #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, then I guess the max-width of 100% solves the scrolling question unless we intent to remove the |
|
For figures at least, yes (other things like tables still have scrolling issues). You are not a fan of using |
|
I do like max-width 100%, for enlarging it, a Lightbox-like solution would have my preference (if ever needed of course). The scrolling issue for tables should be fixed in #174 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @hoetmaaiers I added a larger image to the demo site. But this mostly already seems to work OK (similar to bootstrap's img-fluid), since sphinx includes a
max-width: 100%forimg