Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency refinement sparse, numba #158

Closed
zklaus opened this issue Mar 17, 2022 · 2 comments · Fixed by #168
Closed

Dependency refinement sparse, numba #158

zklaus opened this issue Mar 17, 2022 · 2 comments · Fixed by #168
Assignees
@aulemahal

Comments

@zklaus
Copy link

zklaus commented Mar 17, 2022

Currently, xESMF simply depends on sparse, with no lower bound, and does not depend on numba explicitly.
In conda-forge/esmvaltool-suite-feedstock#5 we ran into a problem where that leads to numba missing because older sparse builds do not depend on it.

I suggest that xESMF depends on numba itself since it is used in smm.py and thus a direct dependency.
I also wonder if you want to place a lower bound on the sparse dependency?
@zklaus zklaus mentioned this issue Mar 17, 2022
Merged
3 tasks
@raphaeldussin
Copy link
Contributor

@zklaus that sounds like a good solution, what lower bound for sparse are you thinking of?

@zklaus
Copy link
Author

zklaus commented Mar 26, 2022

@raphaeldussin, I don't know about the lower bound on sparse. My thinking was that a lower bound on sparse might pull in numba automatically, but also, I know that sparse has undergone substantial development and I am not sure which version is the oldest that you have done your tests with.

If you add the numba dependency (as I think you should because you are using it directly), there is no technical need for a lower bound on sparse. But if you know or suspect that you need a certain maturity from sparse, you may still consider it.

@andersy005 andersy005 mentioned this issue Apr 5, 2022
Merged
4 tasks
@aulemahal aulemahal mentioned this issue May 13, 2022
Merged
@bouweandela bouweandela mentioned this issue Jul 19, 2022
Merged
8 tasks
bouweandela added a commit to ESMValGroup/ESMValTool that referenced this issue Jul 21, 2022
@bouweandela
Update development infrastructure (#2663)
487d878 
Closes #2606
Closes #2299
Workaround for #2695
Closes ESMValGroup/ESMValCore#1364?

Versioning

    Use setuptools-scm to give a more accurate version number. The version number is built up as follows:
    {major}.{minor}.{patch}.dev{distance}+g{commit}+d{date}.
    Examples:
        For released versions, it will remain unchanged, e.g. 2.5.0
        If there are additional commits since the release, the patch version number will be increased with one and the number of commits since the release and the current commit will be used to generate a more detailed description. For example, if you are on v2.5.0 of the tool and there have been 72 commits in your current branch since that release and the latest commit has the (hexadecimal) number a424c89 (you can find the number of all commits in the current branch by using git log), then the version number will look like this: 2.5.1.dev72+ga424c891d.
        If there are uncommitted changes, the letter d and the current date will be added to the version number, e.g. 2.5.1.dev72+ga424c891d.d20220719

CircleCI

    Use appropriate resources
    Upload compressed artifacts for fast runs
    Upload test results in a format that CircleCI understands, enabling test summaries and statistics
    Only run documentation test nightly, readthedocs build is now configured to fail on warnings

Readthedocs

    Use mamba build
    Fail on warnings

Docker

    Use mamba container as a basis

Python development installation

    Install all development dependencies from conda-forge

R development installation

    Install all development dependencies from conda-forge

Stickler CI

    Remove the configuration file because we are not using this service anymore

Updates to dependencies

    Pin cf-units to a version that is compatible with the tests for the v2.6 release (Test failure due to change in cf-units ESMValCore#1655)
    Pin r-akima (recipe_miles_* broken due to newest akima package versions #2695)
    Pin xesfm to 0.3.0 (Old xesmf version dependency creates problems #2729)
    Remove xesmf dependency numba (Dependency refinement sparse, numba pangeo-data/xESMF#158)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aulemahal aulemahal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix dependencies - sparse and numba pangeo-data/xESMF
3 participants
@zklaus @raphaeldussin @aulemahal