-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature request: async api #134
Comments
Dear Andrea, thank you for writing in.
It isn't planned yet, but we will be happy to take it into consideration.
We can see the need for such scenarios. Let's use this ticket to maybe collect more voices from the community about how strong the needs are beyond your initiative, which we appreciate.
We guess using With kind regards, /cc @hramezani |
On this matter, it was easy to discover those discussions.
Do you have any pragmatic recommendations for us, @hramezani?
|
I've suggested httpx because it's my go-to library for async requests these days, but the trustworthy aiohttp is also an option. |
Hello, There's a 3rd option you may consider, staying with Requests but "upgrading" to https://github.com/jawah/niquests |
Hi again, Niquests, advertising itself as a drop-in replacement for Requests, sounds intriguing 1, so we would like to give it a spin. In order to evaluate interest within the community, please vote 👍 on the original post by @sanzoghenzo. At the same time, a corresponding pull request would be very much welcome. With kind regards, Footnotes |
Thank you for considering Niquests, I'd be happy to help and support the initiative. |
I can see the benefit of a drop in replacement, but since we're talking about switching to async, the drop-in replacement is only half of the sotry: all the methods of the Anyway, I no longer have the need for this request since I only needed a few endpoints, and I was a bit disappointed when I realized that there's no object de/serialization (using dataclasses, pydantic, attrs, msgspec...) in this library. Feel free to close this if nobody else need an async version! |
Hi again. Yesterday, I stumbled upon the universalasync package. Is it something we could leverage here to swap out the proprietary implementation for having support for both sync and async? I did not look into the details, and would like to defer the evaluation to @Ousret, if you can find the time? Cheers, |
If I got it right, this package does not generate async from the sync code. regards, |
Thank you very much for your assessment, when I wasn't able to find the time to do it properly. I absolutely agree, so I am closing this ticket again. 🙇 |
Hi there,
are there any plans to support/switch to an async client like httpx in place of requests?
It would be useful for using it within web services without blocking concurrency.
The text was updated successfully, but these errors were encountered: