Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribute ES5, not ES6 #1

Closed
wants to merge 1 commit into from
Closed

Conversation

Borzik
Copy link

@Borzik Borzik commented Jul 31, 2017

ES5 should be distributed for wider support.
Implemented according to this article

@Borzik Borzik force-pushed the es5-support branch 2 times, most recently from 7c2ff30 to df8b9c7 Compare July 31, 2017 10:59
@cscalfani
Copy link
Member

Thanks for the pull request, but I'm not interested in supporting old browsers.

@cscalfani cscalfani closed this Aug 4, 2017
@Borzik
Copy link
Author

Borzik commented Aug 4, 2017

@cscalfani this is not to support old browsers, the main reason is to support uglify-js, and its dependencies. Could you please review your decision? Right now projects which utilize uglify-js (which is quite popular with 22 millions downloads per month) cannot be built without errors if some of their dependencies use ES6 and don't provide ES5 version.

@cscalfani
Copy link
Member

Why not use uglify-es?

@Borzik
Copy link
Author

Borzik commented Aug 4, 2017

For example, Vue CLI uses uglify-js, and rewriting complete configuration (or making babel compile node_modules) doesn't worth the effort - it's easier for me to keep my fork then (luckily this lib in stable state and my fork won't require maintenance at all).
The same can be said about create-react-app, see this issue in their repo

We don't recommend using libraries that don't precompile their code to ES5 but are supposed to be usable in ES5.

@cscalfani
Copy link
Member

I think keeping your fork makes the most sense. My personal philosophy is that one should try to move forward as soon as is reasonable. ES6 is pretty widely supported and I'm surprised there isn't support for it in Vue which is a fairly new framework.

Best of luck.

@gaearon
Copy link

gaearon commented Jan 13, 2018

FYI, we're starting the work to compile deps with babel-preset-env in Create React App: facebook/create-react-app#3776

Let us know if you have feedback about how this should work.

@gaearon
Copy link

gaearon commented Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants