Remove hard-coded WP latest version check #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this way we can use that file to validate against the version of WP that WP is reporting for itself and remove the hard-coded versions
|
Linting is failing due to changes in PHP (or WP) CS relating to this sniff called out in our WP Coding Standards: https://github.com/pantheon-systems/Pantheon-WP-Coding-Standards/blob/main/Pantheon-WP-Minimum/ruleset.xml#L70C20-L70C45 That will need to be addressed separate from this PR |
pwtyler
approved these changes
Dec 8, 2023
Comment on lines
+48
to
+50
| <exclude name="WordPressVIPMinimum.Performance.FetchingRemoteData.FileGetContentsUnknown"> | ||
| <exclude-pattern>*/*</exclude-pattern> | ||
| </exclude> |
There was a problem hiding this comment.
Assuming this is thrown by something in the test, can we exclude there or only for tests, rather than globally?
|
Noting here that there's no need to create a release for this update since it's only affecting testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the WP version handling and testing in the codebase. It includes the following changes:
Copies the
wp-latest.jsonfile from thetmpdirectory into thetestsdirectory. This allows us to validate against the version of WP that WP is reporting for itself and remove the hard-coded versions.Adds a helper method that gets the WP version from
wp-latest.json.Uses the version stored in
wp-latest.jsonfor testing.These changes improve the accuracy and flexibility of WP version handling in the codebase.
This will fix the currently failing tests.