Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SITE-1855] Declare Drupal 11 compatibility #57

Closed
wants to merge 6 commits into from
Closed

Conversation

greg-1-anderson
Copy link
Member

This PR is based on the patch submitted via the project-update-bot on drupal.org.

Pantheon Advanced Page Cache does the following things:

  • It registers a cache tags invalidator (Drupal\Core\Cache\CacheTagsInvalidatorInterface)
  • It registers an event subscriber (Symfony\Component\EventDispatcher\EventSubscriberInterface)
  • It implements hook_ENTITY_TYPE_update()

We know the following:

  • CacheTagsInvalidatorInterface did not change between Drupal 10.x and Drupal 11.x
  • EventSubscriberInterface did not change between Symfony 6.4 and 7
  • The hook and entity system did not change in Drupal 11

This gives us some level of confidence that this level of change should be sufficient for Drupal 11 compatibility, and, in fact, this module does install on a Drupal 11 site.

Tests are currently failing, though, and it would be good to have some level of actual testing done here before assuming we are done.

@greg-1-anderson greg-1-anderson requested a review from a team as a code owner September 25, 2024 23:39
@greg-1-anderson
Copy link
Member Author

Got the tests running again on Drupal 9 and Drupal 10, but the Drupal 11 tests are failing for reasons I can't quite explain (yet).

@greg-1-anderson
Copy link
Member Author

Continued in #58. Force pushing breaks the drupal.org update; re-opening on a new branch rather than manually force-pushing on the drupal.org repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants