Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix queries using orderby=>meta_value_num #299

Merged
merged 4 commits into from
Jul 10, 2017
Merged

Fix queries using orderby=>meta_value_num #299

merged 4 commits into from
Jul 10, 2017

Conversation

danielbachhuber
Copy link
Contributor

Fixes #298

@danielbachhuber danielbachhuber added this to the 1.3.1 milestone Jul 10, 2017
@danielbachhuber danielbachhuber mentioned this pull request Jul 10, 2017
Closed
ataylorme
ataylorme suggested changes Jul 10, 2017
View reviewed changes
Copy link
Contributor

@ataylorme ataylorme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the change log with the fix. I would like to do this for all PRs going forward. It will make releases much quicker since I won't need to go back through merged items to update the change log on release

@danielbachhuber
Copy link
Contributor Author

Please update the change log with the fix.

Updated.

I would like to do this for all PRs going forward. It will make releases much quicker since I won't need to go back through merged items to update the change log on release

Sounds good.

@ataylorme ataylorme merged commit ab1283d into master Jul 10, 2017
@ataylorme ataylorme deleted the 298-orderby-metanum branch July 10, 2017 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ataylorme ataylorme ataylorme approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@danielbachhuber @ataylorme