Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGS-6558] Fix Solr not indexing #598

Merged
merged 4 commits into from
Jul 25, 2023
Merged

[BUGS-6558] Fix Solr not indexing #598

merged 4 commits into from
Jul 25, 2023

Conversation

pwtyler
Copy link
Member

@pwtyler pwtyler commented Jul 25, 2023 •
edited
Loading

Fixes case where wp solr index returns "Success" but wp solr stats shows that nothing is indexed.

solr->update() was not called when $optimize and should_commit are both false.

Props @DmytroLytvynchenko for assisting with the patch.

@jazzsequence jazzsequence marked this pull request as ready for review July 25, 2023 21:45
@jazzsequence jazzsequence requested a review from a team as a code owner July 25, 2023 21:45
@pwtyler pwtyler merged commit 9de6dba into develop Jul 25, 2023
3 checks passed
@pwtyler pwtyler deleted the BUGS-6558 branch July 25, 2023 22:15
@pwtyler pwtyler mentioned this pull request Jul 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jazzsequence jazzsequence jazzsequence approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pwtyler @jazzsequence