Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CMSP-42] Fixed issue with empty/zero value for posts_per_page #599

Merged
merged 6 commits into from
Jul 26, 2023
Merged

[CMSP-42] Fixed issue with empty/zero value for posts_per_page #599

merged 6 commits into from
Jul 26, 2023

Conversation

pwtyler
Copy link
Member

@pwtyler pwtyler commented Jul 25, 2023

Set posts_per_page to default to 1 if not set.

Replaces #567
Fixes #566.

@pwtyler pwtyler marked this pull request as ready for review July 25, 2023 20:59
@pwtyler pwtyler requested a review from a team as a code owner July 25, 2023 20:59
jazzsequence
jazzsequence requested changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@jazzsequence jazzsequence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use posts_per_page value from the database as a default rather than hard-coding to 1.

includes/class-solrpower-wp-query.php Outdated Show resolved Hide resolved
@pwtyler pwtyler linked an issue Jul 26, 2023 that may be closed by this pull request
Divide by zero warning when posting a query #566
Closed
@jazzsequence
Copy link
Contributor

:shipit:

@pwtyler pwtyler merged commit a838aa1 into develop Jul 26, 2023
4 checks passed
@pwtyler pwtyler deleted the CMSP-42 branch July 26, 2023 16:41
@pwtyler pwtyler mentioned this pull request Jul 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jazzsequence jazzsequence jazzsequence approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Divide by zero warning when posting a query
3 participants
@pwtyler @jazzsequence @threeiem