Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGS-6792] clear_object_cache handles protected cache property (OCP) #611

Merged
merged 4 commits into from
Sep 12, 2023

Conversation

pwtyler
Copy link
Member

@pwtyler pwtyler commented Sep 12, 2023

Plugin was written with wp-redis in mind, but OCP's cache property is private where wp-redis is not.

Fixes #610

Tested on solr-power site with both OCP and wp-redis installed (else debug statements in below output excised from final version).

OCP

philtyler@Phils-MacBook-Pro solr-power % terminus remote:wp ... -- solr index
 [warning] This environment is in read-only Git mode. If you want to make changes to the codebase of this site (e.g. updating modules or plugins), you will need to toggle into read/write SFTP mode first.

Starting batch 1 of 1 at 0:00:00 elapsed time (0 indexed, 0 failed, 1 remaining)

Submitted 'Let's Go Car Shopping!' (1) to the index.
Property group_ops DNE!1
Property stats DNE!1
Property memcache_debug DNE!1
Property cache is private or protected1
Success: Indexed 1 of 1 posts.
 [notice] Command: ... -- wp solr index [Exit: 0]

Wp Redis

philtyler@Phils-MacBook-Pro solr-power % terminus remote:wp ... -- solr index

Starting batch 1 of 1 at 0:00:00 elapsed time (0 indexed, 0 failed, 1 remaining)

Submitted 'Let's Go Car Shopping!' (1) to the index.
Property group_ops DNE!1
Property stats DNE!1
Property memcache_debug DNE!1
Success: Indexed 1 of 1 posts.
 [notice] Command: ... -- wp solr index [Exit: 0]

@pwtyler pwtyler marked this pull request as ready for review September 12, 2023 19:45
@pwtyler pwtyler requested a review from a team as a code owner September 12, 2023 19:45
Copy link
Contributor

@jazzsequence jazzsequence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pwtyler pwtyler merged commit 4db3715 into develop Sep 12, 2023
4 checks passed
@pwtyler pwtyler deleted the BUGS-6792 branch September 12, 2023 20:23
@pwtyler pwtyler mentioned this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants