Add is_search check to found_posts_query filter #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This limits clearing of found posts query to solr searching. Always returning blank breaks paging within wp install on non-search pages.
|
Thanks for the Pull Request. Can you explain in a bit more detail how we can replicate the issue you are solving with this change? |
Closed
|
Yes, on other pages of our site where paging is used such as archive pages, blanking the found posts query causes WP to pull the ID of a post from the original query as the found posts count. So we were ending up with a post count of over 20,000 (our post id was 20848), which made a lot of empty pages. It's easiest to replicate with archives and then set your posts per page really low in the reading settings. |
|
Ok this is definitely a blocker for the next release. Thanks for the Pull Request! |
|
@joshkoenig Just tested this and it resolves the issue with pagination. Great catch @yvickers-rci! |
|
+1 Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This limits clearing of found posts query to solr searching. Always returning blank breaks paging within wp install on non-search pages.