Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jfdi] Add phpcbf before lint #380

Merged
merged 21 commits into from
Jul 18, 2024
Merged

[jfdi] Add phpcbf before lint #380

merged 21 commits into from
Jul 18, 2024

Conversation

jazzsequence
Copy link
Contributor

@jazzsequence jazzsequence commented Jul 18, 2024

This PR adds a phpcbf step before the linting to commit anything that cbf could fix before running the linter. This makes it so things like this don't block being able to merge PRs.

@jazzsequence jazzsequence changed the title Add-phpcbf-before-lint [jfdi] Add phpcbf before lint Jul 18, 2024
@jazzsequence jazzsequence marked this pull request as ready for review July 18, 2024 15:00
@jazzsequence jazzsequence requested a review from a team as a code owner July 18, 2024 15:00
@jazzsequence jazzsequence requested a review from pwtyler July 18, 2024 15:00
@pwtyler pwtyler changed the base branch from master to develop July 18, 2024 17:13
@jazzsequence jazzsequence requested a review from pwtyler July 18, 2024 17:23
Copy link

Hi from your friendly robot! 🤖 I fixed PHPCS issues with phpcbf on 6d7babc. Please review the changes.

@jazzsequence jazzsequence merged commit 250cc45 into develop Jul 18, 2024
6 checks passed
@jazzsequence jazzsequence deleted the add-phpcbf-before-lint branch July 18, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants