[CMS-859] Add theme vulnerability check #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When this command runs on the platform, it does not explicitly utilize the --all flag, but that’s because the plugin command (which does have an option for --all) does not actually implement this logic - it will pull all plugins and makes no distinction whether they’re active or not. This commit will just assume that when anyone (including the platform) runs the “all” command, it will expect the --all flag is enabled.
|
Thanks @kyletaylored ! @greg-1-anderson Up for building this into the Phar when you have a moment? |
When this command runs on the platform, it does not explicitly utilize the --all flag, but that’s because the plugin command (which does have an option for --all) does not actually implement this logic - it will pull all plugins and makes no distinction whether they’re active or not. This commit will just assume that when anyone (including the platform) runs the “all” command, it will expect the --all flag is enabled.
…heck into add-theme-check # Conflicts: # .travis.yml
kyletaylored
force-pushed
the
add-theme-check
branch
from
93e8b52
to
c940821
Compare
|
Build reports:
|
|
@danielbachhuber I had committed a lot here, some of it to try and get successful tests to run on TravisCI, so I went ahead and started a TravisCI to Github Actions migration (#107) which should probably get merged first, then we can start adding in these updates. What do you think @greg-1-anderson? |
|
Yeah, looks good to me. Let's rebase this against #107 after that PR is merged. |
kyletaylored
changed the title
jazzsequence
approved these changes
Jul 29, 2022
CdrMarks
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though we use WPScan (formerly WPVulnDB), we only made use of the plugin vulnerabilities and never the theme vulnerabilities. This PR adds in a new command for checking the themes, similar to how
wp launchcheck pluginsworks.There are also a few typos and grammar pieces that were fixed as well.