Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMS-859] Fix behat errors #126

Merged
merged 6 commits into from
Aug 3, 2022
Merged

[CMS-859] Fix behat errors #126

merged 6 commits into from
Aug 3, 2022

Conversation

jazzsequence
Copy link
Contributor

@jazzsequence jazzsequence commented Aug 2, 2022

this updates the behat launchcheck theme tests.
Since the plugin tests only check for updates and the test environment is not using an api key for WPscan, the theme tests follow suit and only test updates rather than vulnerabilities (which fail).

However, the vulnerability scans have been tested locally and do, in fact, work.

@jazzsequence jazzsequence marked this pull request as ready for review August 2, 2022 19:58
@jazzsequence jazzsequence requested a review from a team as a code owner August 2, 2022 19:58
@jazzsequence jazzsequence self-assigned this Aug 2, 2022
@jazzsequence jazzsequence changed the title Fix behat errors [CMS-320] Fix behat errors Aug 3, 2022
Copy link
Contributor

@jspellman814 jspellman814 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jazzsequence jazzsequence merged commit 12a8d6a into main Aug 3, 2022
@jazzsequence jazzsequence deleted the fix-behat-errors branch August 3, 2022 20:08
@CdrMarks CdrMarks changed the title [CMS-320] Fix behat errors [CMS-859] Fix behat errors Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants