[CMS-845] Don't recommend Native PHP Sessions if it's already installed #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
null coalesce doesn't work here because we'd just be passing the result of the isset
there IS a new minor version available
let's see how this goes
|
Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how the messenger class works for the Recommendation line to make it so if no action exists, no recommendation is given. It then changes the sessions sub-command to not define a recommended action if the plugin is already installed.
By necessity, this PR also updates some of the general behat tests (specifically around versions) which updated since the last time tests were run.
This PR also adds new behat tests for the
wp launchcheck sessionssubcommand which previously did not exist. The tests check output: