Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGS-5880] Adjust for multisite checks #142

Merged
merged 19 commits into from
May 16, 2023
Merged

[BUGS-5880] Adjust for multisite checks #142

merged 19 commits into from
May 16, 2023

Conversation

jazzsequence
Copy link
Contributor

@jazzsequence jazzsequence commented May 9, 2023

This PR switches the site to the DOMAIN_CURRENT_SITE if the site is multisite so that checks are run against the main/primary site. This effectively does the same thing that the --url=<primary site url> flag does in WP-CLI.

This had merged #141 but those changes have been backed out in 57f440a

  • The majority of this change is here
  • An additional change was needed in the insecure check to not warn about wp-redis making insecure function calls.
  • The workflow was modified to not test older versions of PHP than 7.4 (8.0+ was tested but those tests failed, so updating was abandoned).
  • Behat tests were updated to fix failing checks

@jazzsequence jazzsequence self-assigned this May 9, 2023
@jazzsequence jazzsequence marked this pull request as ready for review May 15, 2023 21:00
@jazzsequence jazzsequence requested review from a team as code owners May 15, 2023 21:00
@jazzsequence jazzsequence requested a review from pwtyler May 15, 2023 21:37
Copy link
Member

@pwtyler pwtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one vestigial comment to drop.

@@ -30,6 +30,7 @@ Feature: Suggest object cache to be enabled

Scenario: WP Redis is present as the enabled object-cache
Given a WP install
# TODO Remove the version flag.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# TODO Remove the version flag.

@jazzsequence jazzsequence merged commit e10a8a8 into main May 16, 2023
@jazzsequence jazzsequence deleted the bugs-5880 branch May 16, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants