[CMSP-624] Check for and recommend Object Cache Pro #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Chris Reynolds <chris@jazzsequence.com>
jazzsequence
requested changes
Aug 23, 2023
There was a problem hiding this comment.
It looks like the first if got swallowed in applying the changes, so there's just a } else { which will be a syntax error and break the command.
The Behat tests should be updated as well so they are passing before we merge this. Let us know if you need us to dig into those.
jazzsequence
requested changes
Aug 23, 2023
There was a problem hiding this comment.
A couple more tweaks to the logic.
- Check if
WP_REDIS_OBJECT_CACHEis defined. This tells us if WP Redis is installed. If it is, give them a message that says "Hey, you should use OCP instead." Otherwise... - Check if
WP_REDIS_CONFIGis defined. In this case we are checking to see if it doesn't exist, because we want to tell them to install it if they don't have it. If it's already defined... - Return success, OCP is found.
I wasn't able to do it in my snippet without breaking things, but with the new elseif it should probably be on the same line as the closing } from the previous if.
jazzsequence
approved these changes
Aug 23, 2023
jazzsequence
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for and recommend Object Cache Pro