Add a pyenv action. #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was using https://github.com/gabrielfalcao/pyenv-action but caching did not work out of the box and my attempts to get it working failed. A read of that action code also seemed to confirm it does not actually cache; it just re-uses the PYENV_ROOT if you've managed to cache it for it.
|
This was developed and proved out as a local action in pex-tool/pex#2168 but I just switched that PR over to this commit and it's humming along demonstrating a correct cache hit for the CPython 2.7.18, 3.5.10 and 3.7.17 versions it's being used for. |
huonw
reviewed
Jul 4, 2023
jsirois
added a commit
to jsirois/pex
that referenced
this pull request
Jul 4, 2023
jsirois
added a commit
to jsirois/pex
that referenced
this pull request
Jul 4, 2023
|
Alright, I have a new run of pex-tool/pex#2168 spinning using these last changes. I nuked the macos cache there so that both cache hit (linux) and cache miss paths are re-confirmed. |
huonw
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using https://github.com/gabrielfalcao/pyenv-action but caching
did not work out of the box and my attempts to get it working failed.
A read of that action code also seemed to confirm it does not actually
cache; it just re-uses the PYENV_ROOT if you've managed to cache it for
it.