-
-
Notifications
You must be signed in to change notification settings - Fork 649
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[internal] Python coverage report generation uses precomputed address…
…es. (#12965) `generate_coverage_reports` requested `Addresses` as an argument, and in common usage, these were computed from the `Specs`. But that will represent an interface leak under #12934 (the only one in the pantsbuild/pants codebase, apparently): it is not expected that the `await Get(CoverageReports, CoverageDataCollection, ..)` union usage would consume the `Specs`; rather: it should operate for its inputs, which might not precisely match the `Specs`. To fix this, consume the `Addresses` associated with the coverage data instead. [ci skip-build-wheels] [ci skip-rust]
- Loading branch information
Showing
1 changed file
with
11 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters