Skip to content

Commit

Permalink
Remove macOS 11 x86_64 wheel builds. (Cherry-pick of #18010) (#18012)
Browse files Browse the repository at this point in the history
These are redundant to the macOS 10.15 x86_64 wheel builds which are
forwards compatible with newer macOS; so we just cause ourselves more
build failures and PyPI more storage / CDN costs than needed.

(cherry picked from commit 07da1d6)
  • Loading branch information
jsirois authored Jan 16, 2023
1 parent 1674755 commit cf8f9ea
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 70 deletions.
69 changes: 0 additions & 69 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -412,74 +412,6 @@ jobs:
name: Deploy to S3
run: ./build-support/bin/deploy_to_s3.py
timeout-minutes: 90
build_wheels_macos11_x86_64:
env:
PANTS_REMOTE_CACHE_READ: 'false'
PANTS_REMOTE_CACHE_WRITE: 'false'
if: ((github.repository_owner == 'pantsbuild') && (github.event_name == 'push'
|| needs.classify_changes.outputs.release == 'true')) && (needs.classify_changes.outputs.docs_only
!= 'true')
name: Build wheels (macOS11-x86_64)
needs:
- classify_changes
runs-on:
- macos-11
steps:
- name: Check out code
uses: actions/checkout@v3
with:
fetch-depth: 10
- name: Expose Pythons
uses: pantsbuild/actions/expose-pythons@627a8ce25d972afa03da1641be9261bbbe0e3ffe
- name: Cache Rust toolchain
uses: actions/cache@v3
with:
key: macOS11-x86_64-rustup-${{ hashFiles('rust-toolchain') }}-v2
path: '~/.rustup/toolchains/1.64.0-*
~/.rustup/update-hashes
~/.rustup/settings.toml
'
- name: Cache Cargo
uses: benjyw/rust-cache@461b9f8eee66b575bce78977bf649b8b7a8d53f1
with:
cache-bin: 'false'
shared-key: engine
workspaces: src/rust/engine
- if: github.event_name != 'pull_request'
name: Setup toolchain auth
run: 'echo TOOLCHAIN_AUTH_TOKEN="${{ secrets.TOOLCHAIN_AUTH_TOKEN }}" >> $GITHUB_ENV
'
- env:
ARCHFLAGS: -arch x86_64
name: Build wheels
run: '[[ "${GITHUB_EVENT_NAME}" == "pull_request" ]] && export MODE=debug
USE_PY39=true ./build-support/bin/release.sh build-local-pex
./build-support/bin/release.sh build-wheels
USE_PY38=true ./build-support/bin/release.sh build-wheels
USE_PY39=true ./build-support/bin/release.sh build-wheels'
- continue-on-error: true
if: always()
name: Upload pants.log
uses: actions/upload-artifact@v3
with:
name: pants-log-wheels-macOS11-x86_64
path: .pants.d/pants.log
- env:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
if: github.event_name == 'push'
name: Deploy to S3
run: ./build-support/bin/deploy_to_s3.py
timeout-minutes: 90
check_labels:
if: github.repository_owner == 'pantsbuild'
name: Ensure PR has a category label
Expand Down Expand Up @@ -598,7 +530,6 @@ jobs:
- build_wheels_linux_x86_64
- build_wheels_macos10_15_x86_64
- build_wheels_macos11_arm64
- build_wheels_macos11_x86_64
- check_labels
- classify_changes
- lint_python
Expand Down
1 change: 0 additions & 1 deletion build-support/bin/generate_github_workflows.py
Original file line number Diff line number Diff line change
Expand Up @@ -660,7 +660,6 @@ def build_wheels_job(platform: Platform, python_versions: list[str]) -> Jobs:
def build_wheels_jobs() -> Jobs:
return {
**build_wheels_job(Platform.LINUX_X86_64, ALL_PYTHON_VERSIONS),
**build_wheels_job(Platform.MACOS11_X86_64, ALL_PYTHON_VERSIONS),
**build_wheels_job(Platform.MACOS10_15_X86_64, ALL_PYTHON_VERSIONS),
**build_wheels_job(Platform.MACOS11_ARM64, [PYTHON39_VERSION]),
}
Expand Down

0 comments on commit cf8f9ea

Please sign in to comment.