Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[internal] Avoid hard dependency on dockerfile #13026

Closed
kaos opened this issue Sep 28, 2021 · 0 comments · Fixed by #13027
Closed

[internal] Avoid hard dependency on dockerfile #13026

kaos opened this issue Sep 28, 2021 · 0 comments · Fixed by #13027
Labels
bug

Comments

@kaos
Copy link
Member

kaos commented Sep 28, 2021

As we don't want to add to the load time of resolving dependencies, we should defer our dependency on the dockerfile package until we actually require it. This also frees us from requiring a workable Go env for platforms where there is no wheel for dockerfile.
Slack thread.
@kaos kaos added the bug label Sep 28, 2021
kaos added a commit to kaos/pants that referenced this issue Sep 28, 2021
@kaos
[Internal] WIP: Refactoring how we integrate with the dockerfile libr…
a7ac76b 
…ary. pantsbuild#13026

[ci skip-rust]

[ci skip-build-wheels]
@kaos kaos mentioned this issue Sep 28, 2021
Merged
kaos added a commit that referenced this issue Sep 30, 2021
@kaos
[Internal] Refactoring how we integrate with dockerfile (#13027)
7adc235 
Rather than having it as a direct dependency, package it into a PEX tool that we run out of process on demand.

Closes #13026.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Internal] Refactoring how we integrate with dockerfile kaos/pants
1 participant
@kaos