Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation tests post inference #13056

Closed
stuhood opened this issue Sep 30, 2021 · 1 comment · Fixed by #13323
Closed

Fix compilation tests post inference #13056

stuhood opened this issue Sep 30, 2021 · 1 comment · Fixed by #13323
Assignees
@stuhood
Labels
backend: JVM JVM backend-related issues estimate: <1W

Comments

@stuhood
Copy link
Member

stuhood commented Sep 30, 2021 •
edited
Loading

A few javac tests began failing while the JVM tests were disabled: see #13046 and #13062.
@stuhood stuhood mentioned this issue Oct 1, 2021
Merged
@stuhood stuhood mentioned this issue Oct 1, 2021
Merged
stuhood added a commit that referenced this issue Oct 1, 2021
@stuhood
[internal] Skip additional inference tests (#13062)
125db0f 
There was a race between #13058 breaking some tests and #13046 re-enabling them.

Adding these to the batch that need fixing as part of #13056.

[ci skip-rust]
[ci skip-build-wheels]
@tdyas tdyas mentioned this issue Oct 1, 2021
Merged
tdyas pushed a commit that referenced this issue Oct 1, 2021
[internal] java: fix version in test (#13064)
92aee22 
As per #13056, fix a failing test that relies on trying to install an older "zulu" JDK version that does not exist on all platforms.

[ci skip-rust]

[ci skip-build-wheels]
@stuhood stuhood added the backend: JVM JVM backend-related issues label Oct 1, 2021
@stuhood
Copy link
Member Author

stuhood commented Oct 1, 2021

Some of these are fixed in #13074, but the remainder should be fixed in #13055.

@stuhood stuhood assigned stuhood and unassigned patricklaw and tdyas Oct 22, 2021
@stuhood stuhood mentioned this issue Oct 22, 2021
Merged
stuhood added a commit that referenced this issue Oct 22, 2021
@stuhood
[internal] Re-enable skipped JVM inference tests. (#13323)
ad8807d 
Fixes #13056.

[ci skip-build-wheels]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stuhood stuhood

Labels
backend: JVM JVM backend-related issues estimate: <1W
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[internal] Re-enable skipped JVM inference tests. stuhood/pants
3 participants
@stuhood @patricklaw @tdyas