Add Python 3.8 to CI #11023
Merged
Add Python 3.8 to CI #11023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thamenato
reviewed
Oct 22, 2020
# Conflicts: # .travis.yml # build-support/bin/generate_travis_yml.py
# Conflicts: # .travis.yml # build-support/bin/generate_travis_yml.py
# Conflicts: # .travis.yml # build-support/bin/generate_travis_yml.py
# Conflicts: # .travis.yml # build-support/bin/generate_travis_yml.py # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
commented
Jan 13, 2021
Comment on lines
153
to
156
| object_docstring = object.__doc__ | ||
| assert object_docstring is not None | ||
| assert ( | ||
| get_docstring(FallbackToObject, fallback_to_ancestors=True, ignored_ancestors=[]) | ||
| == object.__doc__ | ||
| get_docstring(FallbackToObject, fallback_to_ancestors=True, ignored_ancestors=[]) == object_docstring.rstrip() |
There was a problem hiding this comment.
On 3.8, there's an extra \n in the docstring for object. MyPy complained that __doc__ is Optional, so we need to make MyPy happy.
|
Green CI run of 3.8: https://travis-ci.com/github/pantsbuild/pants/builds/212945548. The only failure is from MyPy, which I fixed in the recent push and I'm assuming will be the same error regardless of 3.7 vs. 3.8. |
jsirois
approved these changes
Jan 13, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.