[internal] Require the rust-std component in rustup.
#11422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
|
I don't know how this was missed in #11420: the relevant failing shard did run. Will clear caches for these runs. |
This was referenced Jan 6, 2021
|
The failure in #11415 is (now): https://travis-ci.com/github/pantsbuild/pants/jobs/469295756: |
gshuflin
approved these changes
Jan 6, 2021
stuhood
added a commit
to stuhood/pants
that referenced
this pull request
Jan 6, 2021
Followup to pantsbuild#11420: we additionally need the stdlib.
stuhood
added a commit
that referenced
this pull request
Jan 7, 2021
…11420). (#11423) ### Problem The default components installed for a `rustup` toolchain are not guaranteed to include `cargo`, `clippy`, etc. ### Solution Expand our `rust-toolchain` file to explicitly list the components that we need. We do not pin `rustup` for now, as it generally changes backwards-compatibly. We can revisit that in the future if it continues to change in breaking ways. [ci skip-build-wheels]
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #11420: we additionally need the stdlib.