Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade smallvec to fix insert_many vulnerability. #11449

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

jsirois
Copy link
Contributor

@jsirois jsirois commented Jan 11, 2021

@jsirois
Copy link
Contributor Author

jsirois commented Jan 11, 2021

The issue was surfaced in CI CRON: https://travis-ci.com/github/pantsbuild/pants/builds/212643465?utm_medium=notification&utm_source=email and I was the lucky winner of the CI failure email.

The change was mechanical:

$ ./cargo update --package smallvec
error: There are multiple `smallvec` packages in your project, and the specification `smallvec` is ambiguous.
Please re-run this command with `-p <spec>` where `<spec>` is one of the following:
  smallvec:0.6.13
  smallvec:1.5.1
$ ./cargo update -p smallvec:0.6.13
    Updating crates.io index
    Updating smallvec v0.6.13 -> v0.6.14
$ ./cargo update -p smallvec:1.5.1
    Updating crates.io index
    Updating smallvec v1.5.1 -> v1.6.1

@jsirois jsirois requested a review from gshuflin January 11, 2021 14:40
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stuhood stuhood merged commit d87272f into pantsbuild:master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants