Revert "Temporarily disable the Toolchain plugin to facilitate landing Python 3.9 (#11466)" #11473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g Python 3.9 (pantsbuild#11466)" This reverts commit a8c0f7b. [ci skip-rust] [ci skip-build-wheels]
asherf
reviewed
Jan 15, 2021
pants.toml
Outdated
| # "toolchain.pants.plugin==0.3.0", | ||
| #] | ||
| plugins = [ | ||
| "toolchain.pants.plugin==0.3.0", |
There was a problem hiding this comment.
you can update to 0.4.0 which supports python 3.9.
see #11471
There was a problem hiding this comment.
I don't think that will fully solve the problem - the issue iiuc is the dependency on pantsbuild.pants, which has no Py39 wheel to install. But this is a good change made regardless, so sg.
asherf
approved these changes
Jan 15, 2021
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a8c0f7b.
We decided that we are going to put on hold releasing Pants with Python 3.9 for a week so that we can focus on remote caching.
[ci skip-rust]
[ci skip-build-wheels]