Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite remote_cache_tests.rs to mock the local runner #11474

Merged
merged 11 commits into from
Jan 20, 2021
Merged

Rewrite remote_cache_tests.rs to mock the local runner #11474

merged 11 commits into from
Jan 20, 2021

Commits on Jan 15, 2021

  1. Simplify return types of some test utils 

    # Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
    @Eric-Arellano
    Eric-Arellano committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    02d2b99 View commit details
    Browse the repository at this point in the history

  2. WIP to save my progress with laptop crash 

    [ci skip-build-wheels]
    @Eric-Arellano
    Eric-Arellano committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    cd018bc View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2021

  1. Try to add StubActionCache::insert

    @Eric-Arellano
    Eric-Arellano committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    730e142 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2021

  1. Finish the remote cache reads tests 

    Thanks Tom and Greg!

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
    @Eric-Arellano
    Eric-Arellano committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    8c09866 View commit details
    Browse the repository at this point in the history

  2. Delete old helper functions 

    # Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
    @Eric-Arellano
    Eric-Arellano committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    d53952b View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2021

  1. Rewrite eager_fetch test 

    # Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
    @Eric-Arellano
    Eric-Arellano committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    e8184e0 View commit details
    Browse the repository at this point in the history

  2. Factor setup of the action digest differently 

    We need this for the cache write tests

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
    @Eric-Arellano
    Eric-Arellano committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    4a0e078 View commit details
    Browse the repository at this point in the history

  3. Add StoreSetup to fix the CAS dropping prematurely 

    # Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
    @Eric-Arellano
    Eric-Arellano committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    f29d6ce View commit details
    Browse the repository at this point in the history

  4. Add tests for remote cache writes 

    # Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
    @Eric-Arellano
    Eric-Arellano committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    bc54fe0 View commit details
    Browse the repository at this point in the history

  5. Simplify read tests to not run locally first 

    We already have the atomic counter to keep track of local runs. It was adding unnecessary complexity

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
    @Eric-Arellano
    Eric-Arellano committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    0605574 View commit details
    Browse the repository at this point in the history

  6. Use AtomicUsize instead of Mutex<u32> 

    # Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
    @Eric-Arellano
    Eric-Arellano committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    b053e34 View commit details
    Browse the repository at this point in the history